nix shell/run: Use overlayfs #11706
Open
nix shell/run: Use overlayfs #11706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Amazing!
Did you try to add a test case for this? It may be possible to run this as part of the regular functional test suite in tests/functional/; otherwise it could go in a NixOS VM test, tests/nixos/.
This will inevitably be developed further, to use an "overlay store" if possible, but that is not a requirement yet, so let's just make sure we have a good foundation by having a test for it.
It is also worth a mention in the manual (src/nix/run.md) and perhaps a release note.
edolstra
approved these changes
Oct 16, 2024
tomberek
added
the
idea approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11704